feat: *ByRole a11y value option #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
changed the title
Codecov ReportBase: 94.67% // Head: 94.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
==========================================
+ Coverage 94.67% 94.82% +0.15%
==========================================
Files 42 43 +1
Lines 2946 3036 +90
Branches 440 454 +14
==========================================
+ Hits 2789 2879 +90
Misses 157 157
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mdjastrzebski
force-pushed
the
feature/by-role-a11y-value-props
branch
from
52007ea to
a7e8ff6
Compare
mdjastrzebski
requested review from
AugustinLF,
pierrezimmermannbam and
thymikee
mdjastrzebski
force-pushed
the
feature/by-role-a11y-value-props
branch
2 times, most recently
from
373d4be to
dd27483
Compare
pierrezimmermannbam
approved these changes
Nov 10, 2022
AugustinLF
reviewed
Nov 15, 2022
mdjastrzebski
force-pushed
the
feature/by-role-a11y-value-props
branch
from
afe8402 to
dafbcb2
Compare
AugustinLF
approved these changes
Nov 15, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
valueoption to*ByRolequery*ByA11yValuequery by allowingtextentry to be string or regexTest plan
Added relevant tests for
*ByRolequery and*ByA11yValue.